Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vpn advance config #318

Closed
wants to merge 40 commits into from
Closed

vpn advance config #318

wants to merge 40 commits into from

Conversation

ujjwal-ibm
Copy link
Collaborator

@ujjwal-ibm ujjwal-ibm commented Nov 20, 2023 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISVPNGatewayConnection_basic
=== RUN   TestAccIBMISVPNGatewayConnection_basic
--- PASS: TestAccIBMISVPNGatewayConnection_basic (737.03s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     738.597s

$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISVPNGatewayConnection_route'
=== RUN   TestAccIBMISVPNGatewayConnection_route
--- PASS: TestAccIBMISVPNGatewayConnection_route (440.17s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     442.031s


$ make testacc TEST=./ibm/service/vpc TESTARGS='-run=TestAccIBMISVPNGatewayConnection_multiple'
=== RUN   TestAccIBMISVPNGatewayConnection_multiple
--- PASS: TestAccIBMISVPNGatewayConnection_multiple (397.76s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/vpc     399.720s

deepaksibm
deepaksibm reviewed Mar 18, 2024
View reviewed changes
ibm/service/vpc/resource_ibm_is_vpn_gateway_connections.go
},
},
},
"cidrs": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acceptance test case enhancement for these new values

@ujjwal-ibm ujjwal-ibm closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepaksibm deepaksibm deepaksibm left review comments

@sreekarbvibm sreekarbvibm sreekarbvibm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ujjwal-ibm @deepaksibm @sreekarbvibm